detekt report

Total: 33

complexity: 2

TooManyFunctions: 2 Too many functions inside a/an file/class/object/interface always indicate a violation of the single responsibility principle. Maybe the file/class/object/interface wants to manage too many things at once. Extract functionality which clearly belongs together.

Documentation

Error: src/main/kotlin/dev/nikomaru/advancedshopfinder/gui/FindOptionGui.kt:29:7Class 'FindOptionGui' with '13' functions detected. The maximum allowed functions per class is set to '11'

  26  * 並び順は単一ではなく「優先順位リスト」として編集でき、先頭が第一ソート基準になる。
  27  * クリックで並び順・件数上限・表示フラグを変更し、保存ボタンで永続化する。
  28  */
  29 class FindOptionGui(
  30     private val player: Player,
  31     private val profileName: String,
  32     initial: FindOption,

Error: src/main/kotlin/dev/nikomaru/advancedshopfinder/utils/data/PlayerFindOptionUtils.kt:23:8Object 'PlayerFindOptionUtils' with '12' functions detected. The maximum allowed functions per object is set to '11'

  20  *
  21  * データは `plugins/AdvancedShopFinder/playerdata/<uuid>/config.json` に保存される。
  22  */
  23 object PlayerFindOptionUtils : KoinComponent {
  24     private val plugin: AdvancedShopFinder by inject()
  25 
  26     /** default プロファイルは常に存在し、削除できない。 */

style: 31

MagicNumber: 12 Report magic numbers. Magic number is a numeric literal that is not defined as a constant and hence it's unclear what the purpose of this number is. It's better to declare such numbers as constants and give them a proper name. By default, -1, 0, 1, and 2 are not considered to be magic numbers.

Documentation

Error: src/main/kotlin/dev/nikomaru/advancedshopfinder/gui/FindOptionGui.kt:97:39This expression contains a magic number. Consider defining it to a well named constant.

  94         buySortSlots.forEachIndexed { i, item -> pane.addItem(item, i + 1, 1) }
  95         pane.addItem(sellLabelItem, 0, 2)
  96         sellSortSlots.forEachIndexed { i, item -> pane.addItem(item, i + 1, 2) }
  97         pane.addItem(buyLimitItem, 1, 3)
  98         pane.addItem(sellLimitItem, 3, 3)
  99         pane.addItem(noStockItem, 5, 3)
 100         pane.addItem(ownerMoneyItem, 7, 3)

Error: src/main/kotlin/dev/nikomaru/advancedshopfinder/gui/FindOptionGui.kt:98:37This expression contains a magic number. Consider defining it to a well named constant.

  95         pane.addItem(sellLabelItem, 0, 2)
  96         sellSortSlots.forEachIndexed { i, item -> pane.addItem(item, i + 1, 2) }
  97         pane.addItem(buyLimitItem, 1, 3)
  98         pane.addItem(sellLimitItem, 3, 3)
  99         pane.addItem(noStockItem, 5, 3)
 100         pane.addItem(ownerMoneyItem, 7, 3)
 101         pane.addItem(activeItem, 2, 5)

Error: src/main/kotlin/dev/nikomaru/advancedshopfinder/gui/FindOptionGui.kt:98:40This expression contains a magic number. Consider defining it to a well named constant.

  95         pane.addItem(sellLabelItem, 0, 2)
  96         sellSortSlots.forEachIndexed { i, item -> pane.addItem(item, i + 1, 2) }
  97         pane.addItem(buyLimitItem, 1, 3)
  98         pane.addItem(sellLimitItem, 3, 3)
  99         pane.addItem(noStockItem, 5, 3)
 100         pane.addItem(ownerMoneyItem, 7, 3)
 101         pane.addItem(activeItem, 2, 5)

Error: src/main/kotlin/dev/nikomaru/advancedshopfinder/gui/FindOptionGui.kt:99:35This expression contains a magic number. Consider defining it to a well named constant.

  96         sellSortSlots.forEachIndexed { i, item -> pane.addItem(item, i + 1, 2) }
  97         pane.addItem(buyLimitItem, 1, 3)
  98         pane.addItem(sellLimitItem, 3, 3)
  99         pane.addItem(noStockItem, 5, 3)
 100         pane.addItem(ownerMoneyItem, 7, 3)
 101         pane.addItem(activeItem, 2, 5)
 102         pane.addItem(saveItem, 4, 5)

Error: src/main/kotlin/dev/nikomaru/advancedshopfinder/gui/FindOptionGui.kt:99:38This expression contains a magic number. Consider defining it to a well named constant.

  96         sellSortSlots.forEachIndexed { i, item -> pane.addItem(item, i + 1, 2) }
  97         pane.addItem(buyLimitItem, 1, 3)
  98         pane.addItem(sellLimitItem, 3, 3)
  99         pane.addItem(noStockItem, 5, 3)
 100         pane.addItem(ownerMoneyItem, 7, 3)
 101         pane.addItem(activeItem, 2, 5)
 102         pane.addItem(saveItem, 4, 5)

Error: src/main/kotlin/dev/nikomaru/advancedshopfinder/gui/FindOptionGui.kt:100:38This expression contains a magic number. Consider defining it to a well named constant.

  97         pane.addItem(buyLimitItem, 1, 3)
  98         pane.addItem(sellLimitItem, 3, 3)
  99         pane.addItem(noStockItem, 5, 3)
 100         pane.addItem(ownerMoneyItem, 7, 3)
 101         pane.addItem(activeItem, 2, 5)
 102         pane.addItem(saveItem, 4, 5)
 103         pane.addItem(closeItem, 6, 5)

Error: src/main/kotlin/dev/nikomaru/advancedshopfinder/gui/FindOptionGui.kt:100:41This expression contains a magic number. Consider defining it to a well named constant.

  97         pane.addItem(buyLimitItem, 1, 3)
  98         pane.addItem(sellLimitItem, 3, 3)
  99         pane.addItem(noStockItem, 5, 3)
 100         pane.addItem(ownerMoneyItem, 7, 3)
 101         pane.addItem(activeItem, 2, 5)
 102         pane.addItem(saveItem, 4, 5)
 103         pane.addItem(closeItem, 6, 5)

Error: src/main/kotlin/dev/nikomaru/advancedshopfinder/gui/FindOptionGui.kt:101:37This expression contains a magic number. Consider defining it to a well named constant.

  98         pane.addItem(sellLimitItem, 3, 3)
  99         pane.addItem(noStockItem, 5, 3)
 100         pane.addItem(ownerMoneyItem, 7, 3)
 101         pane.addItem(activeItem, 2, 5)
 102         pane.addItem(saveItem, 4, 5)
 103         pane.addItem(closeItem, 6, 5)
 104         gui.addPane(Slot.fromXY(0, 0), pane)

Error: src/main/kotlin/dev/nikomaru/advancedshopfinder/gui/FindOptionGui.kt:102:32This expression contains a magic number. Consider defining it to a well named constant.

  99         pane.addItem(noStockItem, 5, 3)
 100         pane.addItem(ownerMoneyItem, 7, 3)
 101         pane.addItem(activeItem, 2, 5)
 102         pane.addItem(saveItem, 4, 5)
 103         pane.addItem(closeItem, 6, 5)
 104         gui.addPane(Slot.fromXY(0, 0), pane)
 105         redraw()

Error: src/main/kotlin/dev/nikomaru/advancedshopfinder/gui/FindOptionGui.kt:102:35This expression contains a magic number. Consider defining it to a well named constant.

  99         pane.addItem(noStockItem, 5, 3)
 100         pane.addItem(ownerMoneyItem, 7, 3)
 101         pane.addItem(activeItem, 2, 5)
 102         pane.addItem(saveItem, 4, 5)
 103         pane.addItem(closeItem, 6, 5)
 104         gui.addPane(Slot.fromXY(0, 0), pane)
 105         redraw()

Error: src/main/kotlin/dev/nikomaru/advancedshopfinder/gui/FindOptionGui.kt:103:33This expression contains a magic number. Consider defining it to a well named constant.

 100         pane.addItem(ownerMoneyItem, 7, 3)
 101         pane.addItem(activeItem, 2, 5)
 102         pane.addItem(saveItem, 4, 5)
 103         pane.addItem(closeItem, 6, 5)
 104         gui.addPane(Slot.fromXY(0, 0), pane)
 105         redraw()
 106     }

Error: src/main/kotlin/dev/nikomaru/advancedshopfinder/gui/FindOptionGui.kt:103:36This expression contains a magic number. Consider defining it to a well named constant.

 100         pane.addItem(ownerMoneyItem, 7, 3)
 101         pane.addItem(activeItem, 2, 5)
 102         pane.addItem(saveItem, 4, 5)
 103         pane.addItem(closeItem, 6, 5)
 104         gui.addPane(Slot.fromXY(0, 0), pane)
 105         redraw()
 106     }

MaxLineLength: 13 Line detected, which is longer than the defined maximum line length in the code style.

Documentation

Error: src/main/kotlin/dev/nikomaru/advancedshopfinder/commands/ShopSearchCommand.kt:75:1Line detected, which is longer than the defined maximum line length in the code style.

  72         sender.sendMessage(message)
  73     }
  74 
  75     suspend fun processShops(shop: List<Shop>, sender: CommandSender, message: Component, sum: Int, options: FindOption, buying: Boolean): Pair<Component, Int> {
  76         var filteredShops = shop.filter {
  77             it.isBuying == buying && (withContext(Dispatchers.minecraft) {
  78                 if (buying) it.remainingSpace else it.remainingStock

Error: src/main/kotlin/dev/nikomaru/advancedshopfinder/commands/ShopSearchCommand.kt:111:1Line detected, which is longer than the defined maximum line length in the code style.

 108                 async(Dispatchers.async) {
 109                     val luminescenceShulker = LuminescenceShulker()
 110                     luminescenceShulker.addTarget(sender)
 111                     filteredShops.stream().filter { getPlayerDistance(sender.location, it) < lightningDistance }.forEach {
 112                             luminescenceShulker.addBlock(it.location)
 113                         }
 114                     repeat(lightningCount) {

Error: src/main/kotlin/dev/nikomaru/advancedshopfinder/commands/ShopSearchCommand.kt:129:1Line detected, which is longer than the defined maximum line length in the code style.

 126 
 127     private suspend fun sendShopInfo(sender: CommandSender, shopChest: Shop): Component {
 128         val nearPlace = getNearPlace(shopChest)
 129         val nearTownDistance = hypot(nearPlace!!.x.toDouble() - shopChest.location.blockX, nearPlace.z.toDouble() - shopChest.location.blockZ)
 130         val playerLocation = if (sender is Player) sender.location else Location(Bukkit.getWorld("world"), 0.0, 0.0, 0.0)
 131         val distance = getPlayerDistance(playerLocation, shopChest)
 132         val count = if (shopChest.isBuying) getBuyingShopCount(shopChest) else getSellingShopCount(shopChest)

Error: src/main/kotlin/dev/nikomaru/advancedshopfinder/commands/ShopSearchCommand.kt:130:1Line detected, which is longer than the defined maximum line length in the code style.

 127     private suspend fun sendShopInfo(sender: CommandSender, shopChest: Shop): Component {
 128         val nearPlace = getNearPlace(shopChest)
 129         val nearTownDistance = hypot(nearPlace!!.x.toDouble() - shopChest.location.blockX, nearPlace.z.toDouble() - shopChest.location.blockZ)
 130         val playerLocation = if (sender is Player) sender.location else Location(Bukkit.getWorld("world"), 0.0, 0.0, 0.0)
 131         val distance = getPlayerDistance(playerLocation, shopChest)
 132         val count = if (shopChest.isBuying) getBuyingShopCount(shopChest) else getSellingShopCount(shopChest)
 133         val tags = getTags(shopChest, count, distance, nearPlace, nearTownDistance)

Error: src/main/kotlin/dev/nikomaru/advancedshopfinder/commands/ShopSearchCommand.kt:159:1Line detected, which is longer than the defined maximum line length in the code style.

 156         }
 157 
 158     private fun getNearestPlaceDistance(shopChest: Shop) =
 159         hypot(getNearPlace(shopChest)!!.x.toDouble() - shopChest.location.blockX, getNearPlace(shopChest)!!.z.toDouble() - shopChest.location.blockZ)
 160 
 161     private fun getTags(shopChest: Shop, count: String, distance: Int, nearPlace: PlaceData, nearTownDistance: Double): Array<TagResolver.Single> {
 162         val mm = MiniMessage.miniMessage()

Error: src/main/kotlin/dev/nikomaru/advancedshopfinder/commands/ShopSearchCommand.kt:161:1Line detected, which is longer than the defined maximum line length in the code style.

 158     private fun getNearestPlaceDistance(shopChest: Shop) =
 159         hypot(getNearPlace(shopChest)!!.x.toDouble() - shopChest.location.blockX, getNearPlace(shopChest)!!.z.toDouble() - shopChest.location.blockZ)
 160 
 161     private fun getTags(shopChest: Shop, count: String, distance: Int, nearPlace: PlaceData, nearTownDistance: Double): Array<TagResolver.Single> {
 162         val mm = MiniMessage.miniMessage()
 163 
 164         return arrayOf(Placeholder.component("player-name", if (shopChest.isUnlimited) {

Error: src/main/kotlin/dev/nikomaru/advancedshopfinder/commands/ShopSearchCommand.kt:168:1Line detected, which is longer than the defined maximum line length in the code style.

 165             Component.text("アドミンショップ")
 166         } else {
 167             Component.text(Bukkit.getOfflinePlayer(shopChest.owner.uniqueId!!).name.toString())
 168         }), Placeholder.component("price", Component.text(shopChest.price.toString())), Placeholder.component("shop-stacking-amount", Component.text(shopChest.shopStackingAmount.toString())), Placeholder.component("count", Component.text(count)), Placeholder.component("world", Component.text(shopChest.location.world.name)), Placeholder.component("x", Component.text(shopChest.location.blockX.toString())), Placeholder.component("y", Component.text(shopChest.location.blockY.toString())), Placeholder.component("z", Component.text(shopChest.location.blockZ.toString())), Placeholder.component("distance", Component.text(distance.toString())), Placeholder.component("near-town", mm.deserialize(nearPlace.placeName)), Placeholder.component("near-town-distance", Component.text(nearTownDistance.toInt().toString())), Placeholder.component("shop-type", mm.deserialize(if (shopChest.isBuying) "<color:red>買取" else "<color:green>販売")))
 169     }
 170 
 171     private suspend fun getSellingShopCount(shopChest: Shop) = withContext(Dispatchers.minecraft) {

Error: src/main/kotlin/dev/nikomaru/advancedshopfinder/commands/utils/parser/MaterialArrayParser.kt:43:1Line detected, which is longer than the defined maximum line length in the code style.

  40             }
  41         val maps = translateManager.getTranslateMap(locale)
  42         val item =
  43             getKeys(maps, input)?.map { keys -> Material.entries.find { NamespacedKey.minecraft(it.translationKey()) == keys } }
  44                 ?: listOf(Material.matchMaterial(input))
  45         val res = item.filter { it != null }.map { it!! }.toTypedArray()
  46         return ArgumentParseResult.success(res)

Error: src/main/kotlin/dev/nikomaru/advancedshopfinder/files/server/Config.kt:49:1Line detected, which is longer than the defined maximum line length in the code style.

  46 data class ConfigData(
  47     val placeData: List<PlaceData>,
  48     val fuzzySearchLimit: Int = 50,
  49     val format: String = "<shop-type>: オーナー:<green><player-name></green> 値段: <green><price>/<shop-stacking-amount></green>個 在庫: <green><count></green> \n座標: <yellow><world></yellow> x:<blue><x></blue> y:<blue><y></blue> z:<blue><z></blue> 距離: <green><distance></green>ブロック 最寄り: <near-town>から<green><near-town-distance></green>ブロック",
  50 )
  51 
  52 @Serializable

Error: src/main/kotlin/dev/nikomaru/advancedshopfinder/gui/FindOptionGui.kt:57:1Line detected, which is longer than the defined maximum line length in the code style.

  54     private val sellLimitItem = GuiItem(ItemStack(Material.HOPPER)) { event ->
  55         event.isCancelled = true
  56         val limit = option.limitAmountOption
  57         option = option.copy(limitAmountOption = limit.copy(sellFindLimit = nextLimit(limit.sellFindLimit, event.click)))
  58         redraw()
  59     }
  60     private val noStockItem = GuiItem(ItemStack(Material.BARRIER)) { event ->

Error: src/main/kotlin/dev/nikomaru/advancedshopfinder/utils/translate/TranslateManagerImpl.kt:39:1Line detected, which is longer than the defined maximum line length in the code style.

  36             return it
  37         }
  38         val classLoader = this.javaClass.classLoader
  39         val inputStream: InputStream = classLoader.getResourceAsStream("minecraft/${locale.toString().lowercase()}.json")!!
  40         val translateMap: Map<NamespacedKey, String> = json.decodeFromStream(MapSerializer(NamespacedKeySerializer, String.serializer()), inputStream)
  41         translateData.data += (locale to translateMap)
  42         return translateMap

Error: src/main/kotlin/dev/nikomaru/advancedshopfinder/utils/translate/TranslateManagerImpl.kt:40:1Line detected, which is longer than the defined maximum line length in the code style.

  37         }
  38         val classLoader = this.javaClass.classLoader
  39         val inputStream: InputStream = classLoader.getResourceAsStream("minecraft/${locale.toString().lowercase()}.json")!!
  40         val translateMap: Map<NamespacedKey, String> = json.decodeFromStream(MapSerializer(NamespacedKeySerializer, String.serializer()), inputStream)
  41         translateData.data += (locale to translateMap)
  42         return translateMap
  43     }

Error: src/main/kotlin/dev/nikomaru/advancedshopfinder/utils/translate/TranslateManagerImpl.kt:66:1Line detected, which is longer than the defined maximum line length in the code style.

  63         for (lang in preloadLang) {
  64             val locale = Locale.of(lang)
  65             val inputStream: InputStream = classLoader.getResourceAsStream("$resourceDir/${lang}.json")!!
  66             val translateMap: Map<NamespacedKey, String> = json.decodeFromStream(MapSerializer(NamespacedKeySerializer, String.serializer()), inputStream)
  67             dataMap[locale] = translateMap
  68         }
  69

NewLineAtEndOfFile: 2 Checks whether files end with a line separator.

Documentation

Error: src/main/kotlin/dev/nikomaru/advancedshopfinder/commands/EnchantFindCommand.kt:59:2The file EnchantFindCommand.kt is not ending with a new line.
```
  56 
  57     }
  58 
  59 }
```
Error: src/main/kotlin/dev/nikomaru/advancedshopfinder/utils/translate/TranslateManagerImpl.kt:94:2The file TranslateManagerImpl.kt is not ending with a new line.
```
  91         }
  92         return files
  93     }
  94 }
```

ReturnCount: 3 Restrict the number of return statements in methods.

Documentation

Error: src/main/kotlin/dev/nikomaru/advancedshopfinder/commands/FuzzySearchCommand.kt:25:17Function fuzzySearch has 3 return statements which exceeds the limit of 2.

  22     private val quickShop: QuickShopAPI by inject()
  23 
  24     @Command("fuzzy-search <name>")
  25     suspend fun fuzzySearch(
  26         sender: CommandSender,
  27         @Argument("name") name: String,
  28         @Flag(value = "profile", aliases = ["p"]) profile: String?,

Error: src/main/kotlin/dev/nikomaru/advancedshopfinder/commands/utils/FindOptionResolver.kt:15:13Function resolveFindOption has 3 return statements which exceeds the limit of 2.

  12  * - フラグ未指定の場合は使用中プロファイル（無ければデフォルト）。
  13  * - フラグ指定かつ該当プロファイルが存在しない場合は、エラーメッセージを送信して null を返す。
  14  */
  15 suspend fun resolveFindOption(
  16     sender: CommandSender,
  17     profile: String?,
  18 ): FindOption? {

Error: src/main/kotlin/dev/nikomaru/advancedshopfinder/search/FuzzySearcher.kt:20:18Function search has 4 return statements which exceeds the limit of 2.

  17     val translateManager: TranslateManager by inject()
  18     val config: ConfigData by inject()
  19 
  20     override fun search(query: Pair<String, Locale>): Either<ShopSearchError, List<Shop>> {
  21         val keys =
  22             translateManager
  23                 .getTranslateMap(query.second)

SafeCast: 1 Prefer to use a safe cast instead of if-else-null.

Documentation

Error: src/main/kotlin/dev/nikomaru/advancedshopfinder/commands/utils/CommandSenderMapper.kt:24:51This cast should be replaced with a safe cast: as?

  21 
  22             override fun getSender(): CommandSender = sender
  23 
  24             override fun getExecutor(): Entity? = if (sender is Entity) sender else null
  25 
  26             override fun withLocation(p0: Location): CommandSourceStack = sender as CommandSourceStack
  27

Metrics

Complexity Report

Issues

complexity: 2

style: 31